diff --git a/README.md b/README.md index ca9d986..337412b 100644 --- a/README.md +++ b/README.md @@ -149,6 +149,8 @@ V::lang('ar'); * `dateBefore` - Field is a valid date and is before the given date * `dateAfter` - Field is a valid date and is after the given date * `contains` - Field is a string and contains the given string + * `subset` - Field is an array or a scalar and all elements are contained in the given array + * `containsUnique` - Field is an array and contains unique values * `creditCard` - Field is a valid credit card number * `instanceOf` - Field contains an instance of the given class * `optional` - Value does not need to be included in data array. If it is however, it must pass validation. diff --git a/composer.json b/composer.json index 30e5c96..43a760a 100644 --- a/composer.json +++ b/composer.json @@ -4,8 +4,8 @@ "description": "Simple, elegant, stand-alone validation library with NO dependencies", "keywords": ["validation", "validator", "valid"], "homepage": "http://github.com/vlucas/valitron", - "license" : "BSD-3-Clause", - "authors" : [ + "license": "BSD-3-Clause", + "authors": [ { "name": "Vance Lucas", "email": "vance@vancelucas.com", diff --git a/lang/en.php b/lang/en.php index 10c944b..0c9e5a1 100644 --- a/lang/en.php +++ b/lang/en.php @@ -1,34 +1,38 @@ "is required", - 'equals' => "must be the same as '%s'", - 'different' => "must be different than '%s'", - 'accepted' => "must be accepted", - 'numeric' => "must be numeric", - 'integer' => "must be an integer", - 'length' => "must be %d characters long", - 'min' => "must be at least %s", - 'max' => "must be no more than %s", - 'in' => "contains invalid value", - 'notIn' => "contains invalid value", - 'ip' => "is not a valid IP address", - 'email' => "is not a valid email address", - 'url' => "is not a valid URL", - 'urlActive' => "must be an active domain", - 'alpha' => "must contain only letters a-z", - 'alphaNum' => "must contain only letters a-z and/or numbers 0-9", - 'slug' => "must contain only letters a-z, numbers 0-9, dashes and underscores", - 'regex' => "contains invalid characters", - 'date' => "is not a valid date", - 'dateFormat' => "must be date with format '%s'", - 'dateBefore' => "must be date before '%s'", - 'dateAfter' => "must be date after '%s'", - 'contains' => "must contain %s", - 'boolean' => "must be a boolean", - 'lengthBetween' => "must be between %d and %d characters", - 'creditCard' => "must be a valid credit card number", - 'lengthMin' => "must be at least %d characters long", - 'lengthMax' => "must not exceed %d characters", - 'instanceOf' => "must be an instance of '%s'" + 'required' => "is required", + 'equals' => "must be the same as '%s'", + 'different' => "must be different than '%s'", + 'accepted' => "must be accepted", + 'numeric' => "must be numeric", + 'integer' => "must be an integer", + 'length' => "must be %d characters long", + 'min' => "must be at least %s", + 'max' => "must be no more than %s", + 'in' => "contains invalid value", + 'notIn' => "contains invalid value", + 'ip' => "is not a valid IP address", + 'ipv4' => "is not a valid IPv4 address", + 'ipv6' => "is not a valid IPv6 address", + 'email' => "is not a valid email address", + 'url' => "is not a valid URL", + 'urlActive' => "must be an active domain", + 'alpha' => "must contain only letters a-z", + 'alphaNum' => "must contain only letters a-z and/or numbers 0-9", + 'slug' => "must contain only letters a-z, numbers 0-9, dashes and underscores", + 'regex' => "contains invalid characters", + 'date' => "is not a valid date", + 'dateFormat' => "must be date with format '%s'", + 'dateBefore' => "must be date before '%s'", + 'dateAfter' => "must be date after '%s'", + 'contains' => "must contain %s", + 'boolean' => "must be a boolean", + 'lengthBetween' => "must be between %d and %d characters", + 'creditCard' => "must be a valid credit card number", + 'lengthMin' => "must be at least %d characters long", + 'lengthMax' => "must not exceed %d characters", + 'instanceOf' => "must be an instance of '%s'", + 'containsUnique' => "must contain unique elements only", + 'subset' => "contains an item that is not in the list", ); diff --git a/lang/ru.php b/lang/ru.php index 37c914c..44957b2 100644 --- a/lang/ru.php +++ b/lang/ru.php @@ -1,34 +1,38 @@ "обязательно для заполнения", - 'equals' => "должно содержать '%s'", - 'different' => "должно отличаться от '%s'", - 'accepted' => "должно быть указано", - 'numeric' => "должно содержать числовое значение", - 'integer' => "должно быть числом", - 'length' => "должно быть длиннее, чем %d", - 'min' => "должно быть больше, чем %s", - 'max' => "должно быть меньше, чем %s", - 'in' => "содержит неверное значение", - 'notIn' => "содержит неверное значение", - 'ip' => "не является валидным IP адресом", - 'email' => "не является валидным email адресом", - 'url' => "не является валидной ссылкой", - 'urlActive' => "содержит не активную ссылку", - 'alpha' => "должно содержать только латинские символы", - 'alphaNum' => "должно содержать только латинские символы и/или цифры", - 'slug' => "должно содержать только латинские символы, цифры, тире и подчёркивания", - 'regex' => "содержит недопустимые символы", - 'date' => "не является датой", - 'dateFormat' => "должно содержать дату следующего формата: %s", - 'dateBefore' => "должно содержать дату не позднее, чем %s", - 'dateAfter' => "должно содержать дату не ранее, чем %s", - 'contains' => "должно содержать %s", - 'boolean' => "должно содержать логическое значение", - 'lengthBetween' => "должно содержать от %d до %d символов", - 'creditCard' => "должно быть номером кредитной карты", - 'lengthMin' => "должно содержать более %d символов", - 'lengthMax' => "должно содержать менее %d символов", - 'instanceOf' => "должно быть объектом класса '%s'" + 'required' => "обязательно для заполнения", + 'equals' => "должно совпадать со значением '%s'", + 'different' => "должно отличаться от '%s'", + 'accepted' => "должно быть указано", + 'numeric' => "должно содержать числовое значение", + 'integer' => "должно быть числом", + 'length' => "должно быть длиннее, чем %d", + 'min' => "должно быть не менее, чем %s", + 'max' => "должно быть не более, чем %s", + 'in' => "содержит неверное значение", + 'notIn' => "содержит неверное значение", + 'ip' => "не является валидным IP адресом", + 'ipv4' => "не является валидным IPv4 адресом", + 'ipv6' => "не является валидным IPv6 адресом", + 'email' => "не является валидным email адресом", + 'url' => "не является валидной ссылкой", + 'urlActive' => "содержит не активную ссылку", + 'alpha' => "должно содержать только латинские символы", + 'alphaNum' => "должно содержать только латинские символы и/или цифры", + 'slug' => "должно содержать только латинские символы, цифры, тире и подчёркивания", + 'regex' => "содержит недопустимые символы", + 'date' => "не является датой", + 'dateFormat' => "должно содержать дату следующего формата: %s", + 'dateBefore' => "должно содержать дату не позднее, чем %s", + 'dateAfter' => "должно содержать дату не ранее, чем %s", + 'contains' => "должно содержать %s", + 'boolean' => "должно содержать логическое значение", + 'lengthBetween' => "должно содержать от %d до %d символов", + 'creditCard' => "должно быть номером кредитной карты", + 'lengthMin' => "должно содержать более %d символов", + 'lengthMax' => "должно содержать менее %d символов", + 'instanceOf' => "должно быть объектом класса '%s'", + 'containsUnique' => "должно содержать только уникальные элементы", + 'subset' => "содержит элемент, не указанный в списке", ); diff --git a/src/Valitron/Validator.php b/src/Valitron/Validator.php index c9fe2f9..93c06be 100644 --- a/src/Valitron/Validator.php +++ b/src/Valitron/Validator.php @@ -172,9 +172,8 @@ class Validator * Validate that two values match * * @param string $field - * @param mixed $value - * @param array $params - * @internal param array $fields + * @param mixed $value + * @param array $params * @return bool */ protected function validateEquals($field, $value, array $params) @@ -188,9 +187,8 @@ class Validator * Validate that a field is different from another field * * @param string $field - * @param mixed $value - * @param array $params - * @internal param array $fields + * @param mixed $value + * @param array $params * @return bool */ protected function validateDifferent($field, $value, array $params) @@ -262,9 +260,8 @@ class Validator * Validate the length of a string * * @param string $field - * @param mixed $value - * @param array $params - * @internal param array $fields + * @param mixed $value + * @param array $params * @return bool */ protected function validateLength($field, $value, $params) @@ -281,10 +278,10 @@ class Validator /** * Validate the length of a string (between) * - * @param string $field - * @param mixed $value - * @param array $params - * @return boolean + * @param string $field + * @param mixed $value + * @param array $params + * @return bool */ protected function validateLengthBetween($field, $value, $params) { @@ -300,7 +297,7 @@ class Validator * @param mixed $value * @param array $params * - * @return boolean + * @return bool */ protected function validateLengthMin($field, $value, $params) { @@ -316,7 +313,7 @@ class Validator * @param mixed $value * @param array $params * - * @return boolean + * @return bool */ protected function validateLengthMax($field, $value, $params) { @@ -346,9 +343,8 @@ class Validator * Validate the size of a field is greater than a minimum value. * * @param string $field - * @param mixed $value - * @param array $params - * @internal param array $fields + * @param mixed $value + * @param array $params * @return bool */ protected function validateMin($field, $value, $params) @@ -366,9 +362,8 @@ class Validator * Validate the size of a field is less than a maximum value * * @param string $field - * @param mixed $value - * @param array $params - * @internal param array $fields + * @param mixed $value + * @param array $params * @return bool */ protected function validateMax($field, $value, $params) @@ -408,9 +403,8 @@ class Validator * Validate a field is contained within a list of values * * @param string $field - * @param mixed $value - * @param array $params - * @internal param array $fields + * @param mixed $value + * @param array $params * @return bool */ protected function validateIn($field, $value, $params) @@ -432,9 +426,8 @@ class Validator * Validate a field is not contained within a list of values * * @param string $field - * @param mixed $value - * @param array $params - * @internal param array $fields + * @param mixed $value + * @param array $params * @return bool */ protected function validateNotIn($field, $value, $params) @@ -446,8 +439,8 @@ class Validator * Validate a field contains a given string * * @param string $field - * @param mixed $value - * @param array $params + * @param string $value + * @param array $params * @return bool */ protected function validateContains($field, $value, $params) @@ -464,7 +457,6 @@ class Validator $strict = (bool)$params[1]; } - $isContains = false; if ($strict) { if (function_exists('mb_strpos')) { $isContains = mb_strpos($value, $params[0]) !== false; @@ -481,6 +473,46 @@ class Validator return $isContains; } + /** + * Validate that all field values contains a given array + * + * @param string $field + * @param array $value + * @param array $params + * @return bool + */ + protected function validateSubset($field, $value, $params) + { + if (!isset($params[0])) { + return false; + } + if (!is_array($params[0])) { + $params[0] = array($params[0]); + } + if (is_scalar($value)) { + return $this->validateIn($field, $value, $params); + } + + $intersect = array_intersect($value, $params[0]); + return array_diff($value, $intersect) === array_diff($intersect, $value); + } + + /** + * Validate that field array has only unique values + * + * @param string $field + * @param array $value + * @return bool + */ + protected function validateContainsUnique($field, $value) + { + if (!is_array($value)) { + return false; + } + + return $value === array_unique($value, SORT_REGULAR); + } + /** * Validate that a field is a valid IP address * @@ -680,9 +712,8 @@ class Validator * Validate that a field matches a date format * * @param string $field - * @param mixed $value - * @param array $params - * @internal param array $fields + * @param mixed $value + * @param array $params * @return bool */ protected function validateDateFormat($field, $value, $params) @@ -696,9 +727,8 @@ class Validator * Validate the date is before a given date * * @param string $field - * @param mixed $value - * @param array $params - * @internal param array $fields + * @param mixed $value + * @param array $params * @return bool */ protected function validateDateBefore($field, $value, $params) @@ -713,9 +743,8 @@ class Validator * Validate the date is after a given date * * @param string $field - * @param mixed $value - * @param array $params - * @internal param array $fields + * @param mixed $value + * @param array $params * @return bool */ protected function validateDateAfter($field, $value, $params) @@ -868,7 +897,14 @@ class Validator return $isInstanceOf; } - //Validate optional field + /** + * Validate optional field + * + * @param $field + * @param $value + * @param $params + * @return bool + */ protected function validateOptional($field, $value, $params) { //Always return true @@ -876,7 +912,7 @@ class Validator } /** - * Get array of fields and data + * Get array of fields and data * * @return array */ @@ -904,12 +940,12 @@ class Validator * Add an error to error messages array * * @param string $field - * @param string $msg - * @param array $params + * @param string $message + * @param array $params */ - public function error($field, $msg, array $params = array()) + public function error($field, $message, array $params = array()) { - $msg = $this->checkAndSetLabel($field, $msg, $params); + $message = $this->checkAndSetLabel($field, $message, $params); $values = array(); // Printed values need to be in string format @@ -933,18 +969,18 @@ class Validator $values[] = $param; } - $this->_errors[$field][] = vsprintf($msg, $values); + $this->_errors[$field][] = vsprintf($message, $values); } /** * Specify validation message to use for error for the last validation rule * - * @param string $msg - * @return $this + * @param string $message + * @return Validator */ - public function message($msg) + public function message($message) { - $this->_validations[count($this->_validations) - 1]['message'] = $msg; + $this->_validations[count($this->_validations) - 1]['message'] = $message; return $this; } @@ -968,7 +1004,7 @@ class Validator } // Catches the case where the data isn't an array or object if (is_scalar($data)) { - return array(NULL, false); + return array(null, false); } $identifier = array_shift($identifiers); // Glob match @@ -984,8 +1020,8 @@ class Validator } return array($values, true); } // Dead end, abort - elseif ($identifier === NULL || !isset($data[$identifier])) { - if ($allow_empty) { + elseif ($identifier === null || ! isset($data[$identifier])) { + if ($allow_empty){ //when empty values are allowed, we only care if the key exists return array(null, array_key_exists($identifier, $data)); } @@ -1006,7 +1042,7 @@ class Validator /** * Run validations and return boolean result * - * @return boolean + * @return bool */ public function validate() { @@ -1053,7 +1089,9 @@ class Validator } } } - if ($set_to_break) break; + if ($set_to_break) { + break; + } } return count($this->errors()) === 0; @@ -1091,11 +1129,10 @@ class Validator /** * Determine whether a field is being validated by the given rule. * - * @param string $name The name of the rule - * @param string $field The name of the field - * @return boolean + * @param string $name The name of the rule + * @param string $field The name of the field + * @return bool */ - protected function hasRule($name, $field) { foreach ($this->_validations as $validation) { @@ -1112,11 +1149,12 @@ class Validator protected static function assertRuleCallback($callback) { if (!is_callable($callback)) { - throw new \InvalidArgumentException('Second argument must be a valid callback. Given argument was not callable.'); + throw new \InvalidArgumentException( + 'Second argument must be a valid callback. Given argument was not callable.' + ); } } - /** * Adds a new validation rule callback that is tied to the current * instance only. @@ -1137,9 +1175,9 @@ class Validator /** * Register new validation rule callback * - * @param string $name - * @param callable $callback - * @param string $message + * @param string $name + * @param callable $callback + * @param string $message * @throws \InvalidArgumentException */ public static function addRule($name, $callback, $message = null) @@ -1154,6 +1192,10 @@ class Validator static::$_ruleMessages[$name] = $message; } + /** + * @param mixed $fields + * @return string + */ public function getUniqueRuleName($fields) { if (is_array($fields)) { @@ -1187,9 +1229,9 @@ class Validator /** * Convenience method to add a single validation rule * - * @param string|callable $rule - * @param array|string $fields - * @return $this + * @param string|callback $rule + * @param array|string $fields + * @return Validator * @throws \InvalidArgumentException */ public function rule($rule, $fields) @@ -1200,8 +1242,8 @@ class Validator if (is_callable($rule) && !(is_string($rule) && $this->hasValidator($rule))) { $name = $this->getUniqueRuleName($fields); - $msg = isset($params[0]) ? $params[0] : null; - $this->addInstanceRule($name, $rule, $msg); + $message = isset($params[0]) ? $params[0] : null; + $this->addInstanceRule($name, $rule, $message); $rule = $name; } @@ -1209,13 +1251,15 @@ class Validator if (!isset($errors[$rule])) { $ruleMethod = 'validate' . ucfirst($rule); if (!method_exists($this, $ruleMethod)) { - throw new \InvalidArgumentException("Rule '" . $rule . "' has not been registered with " . __CLASS__ . "::addRule()."); + throw new \InvalidArgumentException( + "Rule '" . $rule . "' has not been registered with " . get_called_class() . "::addRule()." + ); } } // Ensure rule has an accompanying message - $msgs = $this->getRuleMessages(); - $message = isset($msgs[$rule]) ? $msgs[$rule] : self::ERROR_DEFAULT; + $messages = $this->getRuleMessages(); + $message = isset($messages[$rule]) ? $messages[$rule] : self::ERROR_DEFAULT; // Ensure message contains field label if (function_exists('mb_strpos')) { @@ -1241,8 +1285,7 @@ class Validator * Add label to rule * * @param string $value - * @internal param array $labels - * @return $this + * @return Validator */ public function label($value) { @@ -1255,8 +1298,8 @@ class Validator /** * Add labels to rules * - * @param array $labels - * @return $this + * @param array $labels + * @return Validator */ public function labels($labels = array()) { @@ -1267,29 +1310,29 @@ class Validator /** * @param string $field - * @param string $msg - * @param array $params + * @param string $message + * @param array $params * @return array */ - protected function checkAndSetLabel($field, $msg, $params) + protected function checkAndSetLabel($field, $message, $params) { if (isset($this->_labels[$field])) { - $msg = str_replace('{field}', $this->_labels[$field], $msg); + $message = str_replace('{field}', $this->_labels[$field], $message); if (is_array($params)) { $i = 1; foreach ($params as $k => $v) { $tag = '{field' . $i . '}'; $label = isset($params[$k]) && (is_numeric($params[$k]) || is_string($params[$k])) && isset($this->_labels[$params[$k]]) ? $this->_labels[$params[$k]] : $tag; - $msg = str_replace($tag, $label, $msg); + $message = str_replace($tag, $label, $message); $i++; } } } else { - $msg = str_replace('{field}', ucwords(str_replace('_', ' ', $field)), $msg); + $message = str_replace('{field}', ucwords(str_replace('_', ' ', $field)), $message); } - return $msg; + return $message; } /** @@ -1319,7 +1362,7 @@ class Validator * * @param array $data * @param array $fields - * @return \Valitron\Validator + * @return Validator */ public function withData($data, $fields = array()) { @@ -1332,20 +1375,20 @@ class Validator /** * Convenience method to add validation rule(s) by field * - * @param string field_name - * @param array $rules + * @param string $field + * @param array $rules */ - public function mapFieldRules($field_name, $rules) + public function mapFieldRules($field, $rules) { $me = $this; - array_map(function ($rule) use ($field_name, $me) { + array_map(function ($rule) use ($field, $me) { //rule must be an array $rule = (array)$rule; //First element is the name of the rule - $rule_name = array_shift($rule); + $ruleName = array_shift($rule); //find a custom message, if any $message = null; @@ -1354,7 +1397,7 @@ class Validator unset($rule['message']); } //Add the field and additional parameters to the rule - $added = call_user_func_array(array($me, 'rule'), array_merge(array($rule_name, $field_name), $rule)); + $added = call_user_func_array(array($me, 'rule'), array_merge(array($ruleName, $field), $rule)); if (!empty($message)) { $added->message($message); } @@ -1369,8 +1412,8 @@ class Validator public function mapFieldsRules($rules) { $me = $this; - array_map(function ($field_name) use ($rules, $me) { - $me->mapFieldRules($field_name, $rules[$field_name]); + array_map(function ($field) use ($rules, $me) { + $me->mapFieldRules($field, $rules[$field]); }, array_keys($rules)); } } diff --git a/tests/Valitron/BaseTestCase.php b/tests/Valitron/BaseTestCase.php index ccfc736..40cf559 100644 --- a/tests/Valitron/BaseTestCase.php +++ b/tests/Valitron/BaseTestCase.php @@ -18,7 +18,7 @@ class BaseTestCase extends TestCase protected function resetProperty($name, $value = null) { - $prop = new ReflectionProperty('Valitron\Validator', $name); + $prop = new \ReflectionProperty('Valitron\Validator', $name); $prop->setAccessible(true); $prop->setValue($value); $prop->setAccessible(false); diff --git a/tests/Valitron/ErrorMessagesTest.php b/tests/Valitron/ErrorMessagesTest.php index 94f3333..583b1dd 100644 --- a/tests/Valitron/ErrorMessagesTest.php +++ b/tests/Valitron/ErrorMessagesTest.php @@ -1,4 +1,5 @@ ''), array(), 'en', __DIR__ . '/../lang'); + $v = new Validator(array('name' => ''), array(), 'en', __DIR__ . '/../lang'); $v->rule('required', 'name'); $v->validate(); - $this->assertEquals( $v->errors('name'), array('A value is required for Name')); + $this->assertEquals($v->errors('name'), array('A value is required for Name')); } - public function testMessageWithFieldAndLabelSet(){ - $v = new Validator(array('name'=>''), array(), 'en', __DIR__ . '/../lang'); + public function testMessageWithFieldAndLabelSet() + { + $v = new Validator(array('name' => ''), array(), 'en', __DIR__ . '/../lang'); $v->rule('required', 'name')->label('my name'); $v->validate(); - $this->assertEquals( $v->errors('name'), array('A value is required for my name')); + $this->assertEquals($v->errors('name'), array('A value is required for my name')); } } diff --git a/tests/Valitron/LangTest.php b/tests/Valitron/LangTest.php index 659d5f1..200519f 100644 --- a/tests/Valitron/LangTest.php +++ b/tests/Valitron/LangTest.php @@ -9,7 +9,7 @@ class LangTest extends BaseTestCase } /** - * Lang defined statically should not be overrided by constructor default + * Lang defined statically should not be override by constructor default */ public function testLangDefinedStatically() { @@ -20,7 +20,7 @@ class LangTest extends BaseTestCase } /** - * LangDir defined statically should not be overrided by constructor default + * LangDir defined statically should not be override by constructor default */ public function testLangDirDefinedStatically() { diff --git a/tests/Valitron/MapRulesTest.php b/tests/Valitron/MapRulesTest.php index 46293e4..21e0c3a 100644 --- a/tests/Valitron/MapRulesTest.php +++ b/tests/Valitron/MapRulesTest.php @@ -1,12 +1,11 @@ array( array('threshold' => 50), @@ -36,7 +34,6 @@ class MapRulesTest extends BaseTestCase )); $this->assertFalse($v->validate()); - } public function testMapMultipleFieldsRules() @@ -60,7 +57,6 @@ class MapRulesTest extends BaseTestCase $this->assertFalse($v->validate()); $this->assertFalse($v->errors('myField1')); $this->assertEquals(2, sizeof($v->errors('myField2'))); - } public function testCustomMessageSingleField() @@ -82,10 +78,10 @@ class MapRulesTest extends BaseTestCase { $rules = array( 'myField1' => array( - array('lengthMin', 14, 'message'=>'My Custom Error 1') + array('lengthMin', 14, 'message' => 'My Custom Error 1') ), 'myField2' => array( - array('lengthMin', 14, 'message'=>'My Custom Error 2') + array('lengthMin', 14, 'message' => 'My Custom Error 2') ) ); @@ -100,8 +96,6 @@ class MapRulesTest extends BaseTestCase $errors1 = $v->errors('myField1'); $this->assertEquals('My Custom Error 1', $errors1[0]); - - $errors2 = $v->errors('myField2'); $this->assertEquals('My Custom Error 2', $errors2[0]); } diff --git a/tests/Valitron/StaticVsInstanceTest.php b/tests/Valitron/StaticVsInstanceTest.php index 1601189..174334c 100644 --- a/tests/Valitron/StaticVsInstanceTest.php +++ b/tests/Valitron/StaticVsInstanceTest.php @@ -7,8 +7,9 @@ class StaticVsInstanceTest extends BaseTestCase { Validator::lang('ar'); new Validator(array(), array(), 'en'); - $this->assertEquals('ar', Validator::lang(), - 'instance defined lang should not replace static global lang'); + $this->assertEquals( + 'ar', Validator::lang(), 'instance defined lang should not replace static global lang' + ); } /** diff --git a/tests/Valitron/StopOnFirstFailTest.php b/tests/Valitron/StopOnFirstFailTest.php index 656427d..1e624f6 100644 --- a/tests/Valitron/StopOnFirstFailTest.php +++ b/tests/Valitron/StopOnFirstFailTest.php @@ -1,28 +1,28 @@ array( + array('lengthMin', 5, 'message' => 'myField1 must be 5 characters minimum'), + array('url', 'message' => 'myField1 is not a valid url'), + array('urlActive', 'message' => 'myField1 is not an active url') + ) + ); -class StopOnFirstFail extends BaseTestCase { + $v = new Validator(array( + 'myField1' => 'myVal' + )); - public function testStopOnFirstFail() { - $rules = array( - 'myField1' => array( - array('lengthMin', 5, 'message'=>'myField1 must be 5 characters minimum'), - array('url', 'message' => 'myField1 is not a valid url'), - array('urlActive', 'message' => 'myField1 is not an active url') - ) - ); - - $v = new Validator(array( - 'myField1' => 'myVal' - )); - - $v->mapFieldsRules($rules); - $v->stopOnFirstFail(true); - $this->assertFalse($v->validate()); - - $errors = $v->errors(); - $this->assertCount(1, $errors['myField1']); - } + $v->mapFieldsRules($rules); + $v->stopOnFirstFail(true); + $this->assertFalse($v->validate()); + $errors = $v->errors(); + $this->assertCount(1, $errors['myField1']); + } } diff --git a/tests/Valitron/ValidateAddInstanceRuleTest.php b/tests/Valitron/ValidateAddInstanceRuleTest.php index ddefac3..03cf5cb 100644 --- a/tests/Valitron/ValidateAddInstanceRuleTest.php +++ b/tests/Valitron/ValidateAddInstanceRuleTest.php @@ -1,21 +1,23 @@ validate(); - foreach ($v->errors() as $label => $messages) - { - foreach ($messages as $theMessage) - { + foreach ($v->errors() as $label => $messages) { + foreach ($messages as $theMessage) { $msg .= "\n\t{$label}: {$theMessage}"; } } @@ -30,13 +32,11 @@ class ValidateAddInstanceRuleTest extends BaseTestCase "fuzz" => "bazz", )); - $v->addInstanceRule("fooRule", function($field, $value) - { + $v->addInstanceRule("fooRule", function ($field, $value) { return $field !== "foo" || $value !== "barz"; }); - Validator::addRule("fuzzerRule", function($field, $value) - { + Validator::addRule("fuzzerRule", function ($field, $value) { return $field !== "fuzz" || $value === "bazz"; }); @@ -50,8 +50,7 @@ class ValidateAddInstanceRuleTest extends BaseTestCase public function testAddInstanceRuleFail() { $v = new Validator(array("foo" => "bar")); - $v->addInstanceRule("fooRule", function($field) - { + $v->addInstanceRule("fooRule", function ($field) { return $field === "for"; }); $v->rule("fooRule", "foo"); @@ -61,7 +60,7 @@ class ValidateAddInstanceRuleTest extends BaseTestCase public function testAddAddRuleWithCallback() { $v = new Validator(array("foo" => "bar")); - $v->rule(function($field, $value) { + $v->rule(function ($field, $value) { return $field === "foo" && $value === "bar"; }, "foo"); @@ -71,7 +70,7 @@ class ValidateAddInstanceRuleTest extends BaseTestCase public function testAddAddRuleWithCallbackFail() { $v = new Validator(array("foo" => "baz")); - $v->rule(function($field, $value) { + $v->rule(function ($field, $value) { return $field === "foo" && $value === "bar"; }, "foo"); @@ -81,30 +80,30 @@ class ValidateAddInstanceRuleTest extends BaseTestCase public function testAddAddRuleWithCallbackFailMessage() { $v = new Validator(array("foo" => "baz")); - $v->rule(function($field, $value) { + $v->rule(function ($field, $value) { return $field === "foo" && $value === "bar"; }, "foo", "test error message"); $this->assertFalse($v->validate()); - $errors = $v->errors(); + $errors = $v->errors(); $this->assertArrayHasKey("foo", $errors); $this->assertCount(1, $errors["foo"]); $this->assertEquals("Foo test error message", $errors["foo"][0]); } - public function testAddRuleWithNamedCallbackOk() - { - $v = new Validator(array("bar" => "foo")); - $v->rule("callbackTestFunction", "bar"); - $this->assertFalse($v->validate()); - } + public function testAddRuleWithNamedCallbackOk() + { + $v = new Validator(array("bar" => "foo")); + $v->rule("callbackTestFunction", "bar"); + $this->assertFalse($v->validate()); + } - public function testAddRuleWithNamedCallbackErr() - { - $v = new Validator(array("foo" => "bar")); - $v->rule("callbackTestFunction", "foo"); - $this->assertTrue($v->validate()); - } + public function testAddRuleWithNamedCallbackErr() + { + $v = new Validator(array("foo" => "bar")); + $v->rule("callbackTestFunction", "foo"); + $this->assertTrue($v->validate()); + } public function testUniqueRuleName() { @@ -113,7 +112,8 @@ class ValidateAddInstanceRuleTest extends BaseTestCase $this->assertEquals("foo_bar_rule", $v->getUniqueRuleName($args)); $this->assertEquals("foo_rule", $v->getUniqueRuleName("foo")); - $v->addInstanceRule("foo_rule", function() {}); + $v->addInstanceRule("foo_rule", function () { + }); $u = $v->getUniqueRuleName("foo"); $this->assertRegExp("/^foo_rule_[0-9]{1,5}$/", $u); } diff --git a/tests/Valitron/ValidateTest.php b/tests/Valitron/ValidateTest.php index 614302b..ba59117 100644 --- a/tests/Valitron/ValidateTest.php +++ b/tests/Valitron/ValidateTest.php @@ -913,14 +913,14 @@ class ValidateTest extends BaseTestCase $this->assertTrue($v->validate()); } - public function testContainsNotFound() + public function testContainsInvalid() { $v = new Validator(array('test_string' => 'this is a test')); $v->rule('contains', 'test_string', 'foobar'); $this->assertFalse($v->validate()); } - public function testContainsStrictNotFound() + public function testContainsStrictInvalid() { $v = new Validator(array('test_string' => 'this is a Test')); $v->rule('contains', 'test_string', 'test'); @@ -928,9 +928,98 @@ class ValidateTest extends BaseTestCase } public function testContainsInvalidValue() + { + $v = new Validator(array('test_string' => false)); + $v->rule('contains', 'test_string', 'foobar'); + $this->assertFalse($v->validate()); + } + + public function testContainsInvalidRule() { $v = new Validator(array('test_string' => 'this is a test')); - $v->rule('contains', 'test_string', array('test')); + $v->rule('contains', 'test_string', null); + $this->assertFalse($v->validate()); + } + + public function testSubsetValid() + { + // numeric values + $v = new Validator(array('test_field' => array(81, 3, 15))); + $v->rule('subset', 'test_field', array(45, 15, 3, 7, 28, 81)); + $this->assertTrue($v->validate()); + + // string values + $v = new Validator(array('test_field' => array('white', 'green', 'blue'))); + $v->rule('subset', 'test_field', array('green', 'orange', 'blue', 'yellow', 'white', 'brown')); + $this->assertTrue($v->validate()); + + // mixed values + $v = new Validator(array('test_field' => array(81, false, 'orange'))); + $v->rule('subset', 'test_field', array(45, 'green', true, 'orange', null, 81, false)); + $this->assertTrue($v->validate()); + + // string value and validation target cast to array + $v = new Validator(array('test_field' => 'blue')); + $v->rule('subset', 'test_field', 'blue'); + $this->assertTrue($v->validate()); + } + + public function testSubsetInvalid() + { + $v = new Validator(array('test_field' => array(81, false, 'orange'))); + $v->rule('subset', 'test_field', array(45, 'green', true, 'orange', null, false, 7)); + $this->assertFalse($v->validate()); + } + + public function testSubsetInvalidValue() + { + $v = new Validator(array('test_field' => 'black 45')); + $v->rule('subset', 'test_field', array('black', 45)); + $this->assertFalse($v->validate()); + } + + public function testSubsetInvalidRule() + { + // rule value has invalid type + $v = new Validator(array('test_field' => array('black', 45))); + $v->rule('subset', 'test_field', 'black 45'); + $this->assertFalse($v->validate()); + + // rule value not specified + $v = new Validator(array('test_field' => array('black', 45))); + $v->rule('subset', 'test_field'); + $this->assertFalse($v->validate()); + } + + public function testContainsUniqueValid() + { + // numeric values + $v = new Validator(array('test_field' => array(81, 3, 15))); + $v->rule('containsUnique', 'test_field'); + $this->assertTrue($v->validate()); + + // string values + $v = new Validator(array('test_field' => array('white', 'green', 'blue'))); + $v->rule('containsUnique', 'test_field'); + $this->assertTrue($v->validate()); + + // mixed values + $v = new Validator(array('test_field' => array(81, false, 'orange'))); + $v->rule('containsUnique', 'test_field'); + $this->assertTrue($v->validate()); + } + + public function testContainsUniqueInvalid() + { + $v = new Validator(array('test_field' => array(81, false, 'orange', false))); + $v->rule('containsUnique', 'test_field'); + $this->assertFalse($v->validate()); + } + + public function testContainsUniqueInvalidValue() + { + $v = new Validator(array('test_field' => 'lorem ipsum')); + $v->rule('containsUnique', 'test_field'); $this->assertFalse($v->validate()); } @@ -1213,7 +1302,7 @@ class ValidateTest extends BaseTestCase public function testFalseStillTriggersValidation() { - $v = new Validator(array('test' => FALSE)); + $v = new Validator(array('test' => false)); $v->rule('min', 'test', 5); $this->assertFalse($v->validate()); }