diff --git a/src/Valitron/Validator.php b/src/Valitron/Validator.php index d9fe2f7..0f70856 100644 --- a/src/Valitron/Validator.php +++ b/src/Valitron/Validator.php @@ -251,7 +251,7 @@ class Validator { if (isset($params[0]) && (bool) $params[0]){ //strict mode - return preg_match('/^-?([0-9])+$/i', $value); + return preg_match('/^([0-9]|-[1-9]|-?[1-9][0-9]*)$/i', $value); } return filter_var($value, \FILTER_VALIDATE_INT) !== false; diff --git a/tests/Valitron/ValidateTest.php b/tests/Valitron/ValidateTest.php index 8945032..e25f7a2 100644 --- a/tests/Valitron/ValidateTest.php +++ b/tests/Valitron/ValidateTest.php @@ -203,11 +203,37 @@ class ValidateTest extends BaseTestCase $v->rule('integer', 'num'); $this->assertTrue($v->validate()); - $v = new Validator(array('num' => '+41243')); $v->rule('integer', 'num', true); $this->assertFalse($v->validate()); + $v = new Validator(array('num' => '-1')); + $v->rule('integer', 'num', true); + $this->assertTrue($v->validate()); + + $v = new Validator(array('num' => '-0')); + $v->rule('integer', 'num', true); + $this->assertFalse($v->validate()); + + $v = new Validator(array('num' => '0')); + $v->rule('integer', 'num', true); + $this->assertTrue($v->validate()); + + $v = new Validator(array('num' => '+0')); + $v->rule('integer', 'num', true); + $this->assertFalse($v->validate()); + + $v = new Validator(array('num' => '+1')); + $v->rule('integer', 'num', true); + $this->assertFalse($v->validate()); + + $v = new Validator(array('num' => '0123')); + $v->rule('integer', 'num', true); + $this->assertFalse($v->validate()); + + $v = new Validator(array('num' => '-0123')); + $v->rule('integer', 'num', true); + $this->assertFalse($v->validate()); } public function testIntegerInvalid() @@ -216,7 +242,6 @@ class ValidateTest extends BaseTestCase $v->rule('integer', 'num'); $this->assertFalse($v->validate()); - $v = new Validator(array('num' => '--1231')); $v->rule('integer', 'num'); $this->assertFalse($v->validate());