diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f5a4b05..93e07ad 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -17,8 +17,8 @@ jobs: - '7.2' - '7.3' - '7.4' -# - '8.0' -# - '8.1' + - '8.0' + # - '8.1' steps: - name: Checkout uses: actions/checkout@v2 diff --git a/.gitignore b/.gitignore index 17193f5..12d6107 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,4 @@ composer.phar composer.lock vendor .idea/ +.phpunit.result.cache \ No newline at end of file diff --git a/composer.json b/composer.json index c05eb0f..37c8712 100644 --- a/composer.json +++ b/composer.json @@ -16,7 +16,7 @@ "php": ">=5.3.2" }, "require-dev": { - "phpunit/phpunit": ">=4.8.35 <8" + "phpunit/phpunit": ">=4.8.35" }, "suggest": { "ext-mbstring": "It can support the multiple bytes string length." diff --git a/tests/Valitron/BaseTestCase.php b/tests/Valitron/BaseTestCase.php index 40cf559..5a0d42e 100644 --- a/tests/Valitron/BaseTestCase.php +++ b/tests/Valitron/BaseTestCase.php @@ -4,10 +4,8 @@ use PHPUnit\Framework\TestCase; class BaseTestCase extends TestCase { - public function setUp() - { - } +/* public function tearDown() { $this->resetProperty('_lang'); @@ -23,4 +21,5 @@ class BaseTestCase extends TestCase $prop->setValue($value); $prop->setAccessible(false); } +*/ } diff --git a/tests/Valitron/LangTest.php b/tests/Valitron/LangTest.php index 7cd99c0..f5447cb 100644 --- a/tests/Valitron/LangTest.php +++ b/tests/Valitron/LangTest.php @@ -15,8 +15,8 @@ class LangTest extends BaseTestCase { $lang = 'ar'; Validator::lang($lang); - $validator = new Validator(array()); $this->assertEquals($lang, Validator::lang()); + Validator::lang('en'); } /** @@ -42,13 +42,15 @@ class LangTest extends BaseTestCase $this->assertEquals(realpath($this->getLangDir()), realpath(Validator::langDir())); } - /** - * @expectedException InvalidArgumentException - * @expectedExceptionMessage Fail to load language file '/this/dir/does/not/exists/en.php' - */ + public function testLangException() { + try{ new Validator(array(), array(), 'en', '/this/dir/does/not/exists'); + } catch (Exception $exception){ + $this->assertInstanceOf("InvalidArgumentException", $exception); + $this->assertEquals("Fail to load language file '/this/dir/does/not/exists/en.php'", $exception->getMessage()); + } } diff --git a/tests/Valitron/StaticVsInstanceTest.php b/tests/Valitron/StaticVsInstanceTest.php index 174334c..44bf5c6 100644 --- a/tests/Valitron/StaticVsInstanceTest.php +++ b/tests/Valitron/StaticVsInstanceTest.php @@ -10,6 +10,7 @@ class StaticVsInstanceTest extends BaseTestCase $this->assertEquals( 'ar', Validator::lang(), 'instance defined lang should not replace static global lang' ); + Validator::lang('en'); } /** diff --git a/tests/Valitron/ValidateTest.php b/tests/Valitron/ValidateTest.php index de06b61..a7f7158 100644 --- a/tests/Valitron/ValidateTest.php +++ b/tests/Valitron/ValidateTest.php @@ -4,7 +4,6 @@ use Valitron\Validator; class ValidateTest extends BaseTestCase { - public function testValidWithNoRules() { $v = new Validator(array('name' => 'Chester Tester'));